Repository navigation
[Go] Reject OTF group entries whose blockLength is below the fixed fields - #1187
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…elds. A group header with numInGroup above zero and a blockLength smaller than the fields present at the acting version now panics, so entries cannot be decoded from zero bytes. Constant fields and composite members newer than the acting version must stay excluded from the minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go OTF
DecodeGroupstook the group blockLength from the wire with no lower bound, so a group header with a zero blockLength and a large numInGroup made it fire per-field callbacks numInGroup times over the same bytes. It now panics, as the other length checks in this decoder do, when numInGroup is above zero and blockLength is below the extent of the fixed fields present at the acting version. Constant fields and composite members newer than the acting version are excluded from that extent, mirroring the Java and C++ checks.A message root blockLength below the fixed fields is not checked by this change; the Java and C++ OTF decoders check it, and Go can follow separately.
Part of #969.
Verified: the new
TestRejectsGroupBlockLengthBelowFieldsandTestGroupBlockLengthExcludesMembersNewerThanActingVersionfail on master (no panic) and pass here;gocodemakepasses.